Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove migrated CircleCI jobs and cleanup script #495

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Remove migrated CircleCI jobs and cleanup script #495

merged 1 commit into from
Apr 16, 2024

Conversation

eloquence
Copy link
Member

@eloquence eloquence commented Apr 9, 2024 •
edited
Loading

That part of the job has been migrated to securedrop-yum-test . The remainder will be migrated to securedrop-workstation.

The cleanup script has been split into Debian and RPM portions, which are running in securedrop-apt-test and securedrop-yum-test, respectively.

Update 2024-04-15: Also removes the build/push jobs migrated via freedomofpress/securedrop-workstation#955

legoktm
legoktm requested changes Apr 10, 2024
View reviewed changes
.circleci/config.yml Show resolved Hide resolved
@eloquence eloquence force-pushed the migrate-yum-cleanup branch from 0012328 to 16f651a Compare April 10, 2024 01:18
@eloquence
Copy link
Member Author

RPM build failure potentially related to 4.2 changes that just landed? Can poke tomorrow.

@legoktm
Copy link
Member

legoktm commented Apr 10, 2024

RPM build failure potentially related to 4.2 changes that just landed? Can poke tomorrow.

Yep, and that further justifies putting that nightly logic into the workstation repo...probably we can do that and then come back to this cleanup? I did start in freedomofpress/securedrop-workstation#955, I think it just needs testing.

@eloquence
Copy link
Member Author

Yep, and that further justifies putting that nightly logic into the workstation repo...probably we can do that and then come back to this cleanup? I did start in freedomofpress/securedrop-workstation#955, I think it just needs testing.

OK, since this is directly tied to the 4.2 work, maybe best for you to take that one over the line, and I can take point if review unless someone else grabs it first?

Meanwhile, I can poke at the lint/reprotest jobs in this repo.

@legoktm
Copy link
Member

legoktm commented Apr 11, 2024

OK, since this is directly tied to the 4.2 work, maybe best for you to take that one over the line, and I can take point if review unless someone else grabs it first?

Sounds good!

@eloquence eloquence force-pushed the migrate-yum-cleanup branch from 16f651a to 4b40bc7 Compare April 16, 2024 00:28
@eloquence
Copy link
Member Author

Nightlies triggered directly from securedrop-workstation appear to be working, so I've also removed the build/push CircleCI config in this PR. Once this PR lands, I believe we can safely remove the SSH key associated with this repository as well, as I don't see it being used for anything else.

@eloquence eloquence changed the title Remove migrated CircleCI job and cleanup script Remove migrated CircleCI jobs and cleanup script Apr 16, 2024
legoktm
legoktm approved these changes Apr 16, 2024
View reviewed changes
Copy link
Member

@legoktm legoktm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\o/

I will file an infra ticket to remove the SSH key

@legoktm legoktm merged commit c745098 into main Apr 16, 2024
4 checks passed
@legoktm legoktm deleted the migrate-yum-cleanup branch April 16, 2024 19:33
@legoktm legoktm mentioned this pull request Apr 16, 2024
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legoktm legoktm legoktm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
SecureDrop dev cycle
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eloquence @legoktm